Arbit - project tracking

PHP Depend

#153: The node count analyzer also counts unknown classes.

Issue revisions

  • new by Manuel Pichler at 2010-J-19 9:10
  • new by Manuel Pichler at 2010-J-19 9:11
  • assigned by Manuel Pichler at 2010-J-19 9:13
  • closed by Manuel Pichler at 2010-J-19 9:41
Type bug bug
State closed closed
Priority urgent urgent
Resolution fixed fixed
Assigned to Manuel Pichler
Scheduled for 0.9.16
Affected versions 0.9.14, 0.9.15, 0.9.x, 0.9.x-svn
Affected components Metrics
Last change Saturday 19 June 2010 09:41:36 UTC by Manuel Pichler

Short description

The current implementation of the node count analyzer also counts unknown classes and interface. To solve this problem we should add a check to isUserDefined() into the visitClass() and visitInterface() methods.

// ...
    public function visitClass(PHP_Depend_Code_Class $class)
    {
        if (false === $class->isUserDefined()) {
            return;
        }
        // ...
    }

    // ...

    public function visitInterface(PHP_Depend_Code_Interface $interface)
    {
        if (false === $interface->isUserDefined()) {
            return;
        }
        // ...
    }
// ...

  • Manuel Pichler at Saturday 19 June 2010 09:11:57 UTC

    Scheduled for release 0.9.16

  • Manuel Pichler at Saturday 19 June 2010 09:41:36 UTC

    Fixed in svn revision #1327