PHP Depend, tracked with Arbit

View
History

History

Version 1327

at Saturday 19 June 2010 09:40:45 UTC

by mapi:

- Refs #153: Only count those classes and interfaces that are flagged as user defined types.

Diff

1323	1327	/tests/PHP/Depend/Metrics/NodeCount/AnalyzerTest.php
71	71	class PHP_Depend_Metrics_NodeCount_AnalyzerTest extends PHP_Depend_AbstractTest
72	72	{
73	73	/**
	74	+ * testVisitClassIgnoresClassesThatAreNotUserDefined
	75	+ *
	76	+ * @return void
	77	+ * @covers PHP_Depend_Metrics_NodeCount_Analyzer
	78	+ * @group pdepend
	79	+ * @group pdepend::metrics
	80	+ * @group pdepend::metrics::nodecount
	81	+ * @group unittest
	82	+ */
	83	+ public function testVisitClassIgnoresClassesThatAreNotUserDefined()
	84	+ {
	85	+ $notUserDefined = new PHP_Depend_Code_Class('Pichler');
	86	+
	87	+ $package = new PHP_Depend_Code_Package('PHP_Depend');
	88	+ $package->addType($notUserDefined);
	89	+
	90	+ $analyzer = new PHP_Depend_Metrics_NodeCount_Analyzer();
	91	+ $analyzer->analyze(new PHP_Depend_Code_NodeIterator(array($package)));
	92	+
	93	+ $metrics = $analyzer->getNodeMetrics($package);
	94	+ $this->assertEquals(0, $metrics['noc']);
	95	+ }
	96	+
	97	+ /**
	98	+ * testVisitClassCountsClassesThatAreNotUserDefined
	99	+ *
	100	+ * @return void
	101	+ * @covers PHP_Depend_Metrics_NodeCount_Analyzer
	102	+ * @group pdepend
	103	+ * @group pdepend::metrics
	104	+ * @group pdepend::metrics::nodecount
	105	+ * @group unittest
	106	+ */
	107	+ public function testVisitClassCountsClassesThatAreNotUserDefined()
	108	+ {
	109	+
	110	+ $userDefined = new PHP_Depend_Code_Class('Manuel');
	111	+ $userDefined->setUserDefined();
	112	+
	113	+ $package = new PHP_Depend_Code_Package('PHP_Depend');
	114	+ $package->addType($userDefined);
	115	+
	116	+ $analyzer = new PHP_Depend_Metrics_NodeCount_Analyzer();
	117	+ $analyzer->analyze(new PHP_Depend_Code_NodeIterator(array($package)));
	118	+
	119	+ $metrics = $analyzer->getNodeMetrics($package);
	120	+ $this->assertEquals(1, $metrics['noc']);
	121	+ }
	122	+
	123	+ /**
	124	+ * testVisitClassIgnoresInterfacesThatAreNotUserDefined
	125	+ *
	126	+ * @return void
	127	+ * @covers PHP_Depend_Metrics_NodeCount_Analyzer
	128	+ * @group pdepend
	129	+ * @group pdepend::metrics
	130	+ * @group pdepend::metrics::nodecount
	131	+ * @group unittest
	132	+ */
	133	+ public function testVisitClassIgnoresInterfacesThatAreNotUserDefined()
	134	+ {
	135	+ $notUserDefined = new PHP_Depend_Code_Interface('Pichler');
	136	+
	137	+ $package = new PHP_Depend_Code_Package('PHP_Depend');
	138	+ $package->addType($notUserDefined);
	139	+
	140	+ $analyzer = new PHP_Depend_Metrics_NodeCount_Analyzer();
	141	+ $analyzer->analyze(new PHP_Depend_Code_NodeIterator(array($package)));
	142	+
	143	+ $metrics = $analyzer->getNodeMetrics($package);
	144	+ $this->assertEquals(0, $metrics['noi']);
	145	+ }
	146	+
	147	+ /**
	148	+ * testVisitClassCountsInterfacesThatAreNotUserDefined
	149	+ *
	150	+ * @return void
	151	+ * @covers PHP_Depend_Metrics_NodeCount_Analyzer
	152	+ * @group pdepend
	153	+ * @group pdepend::metrics
	154	+ * @group pdepend::metrics::nodecount
	155	+ * @group unittest
	156	+ */
	157	+ public function testVisitClassCountsInterfacesThatAreNotUserDefined()
	158	+ {
	159	+
	160	+ $userDefined = new PHP_Depend_Code_Interface('Manuel');
	161	+ $userDefined->setUserDefined();
	162	+
	163	+ $package = new PHP_Depend_Code_Package('PHP_Depend');
	164	+ $package->addType($userDefined);
	165	+
	166	+ $analyzer = new PHP_Depend_Metrics_NodeCount_Analyzer();
	167	+ $analyzer->analyze(new PHP_Depend_Code_NodeIterator(array($package)));
	168	+
	169	+ $metrics = $analyzer->getNodeMetrics($package);
	170	+ $this->assertEquals(1, $metrics['noi']);
	171	+ }
	172	+
	173	+ /**
74	174	* Tests that the analyzer calculates the correct number of packages value.
75	175	*
76	176	* @return void
1323	1327	/PHP/Depend/Metrics/NodeCount/Analyzer.php
217	217	*/
218	218	public function visitClass(PHP_Depend_Code_Class $class)
219	219	{
	220	+ if (false === $class->isUserDefined()) {
	221	+ return;
	222	+ }
	223	+
220	224	$this->fireStartClass($class);
221	225
222	226	// Update global class count
269	273	*/
270	274	public function visitInterface(PHP_Depend_Code_Interface $interface)
271	275	{
	276	+ if (false === $interface->isUserDefined()) {
	277	+ return;
	278	+ }
	279	+
272	280	$this->fireStartInterface($interface);
273	281
274	282	// Update global class count
352	360
353	361	$this->fireEndPackage($package);
354	362	}
355		-}
	363	+}

Arbit - project tracking

PHP Depend

History

Version 1327

Diff